hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: A small further performance improvement

Browse Source 
Unrolling the transitive closure had slightly better performance here.

Also, we exclude names of builtins, since those will be handled by a
separate case of `isDefinedLocally`.
This commit is contained in:
Taus
2021-12-09 10:29:55 +00:00
committed by GitHub
parent 8517eff0f7
commit b871342e83
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
python/ql/lib/semmle/python/dataflow/new/internal/ImportStar.qll
View File

@@ -23,7 +23,7 @@ module ImportStar {
cached
private predicate isDefinedLocally(Name n) {
// Defined in an enclosing scope
scope_defines_name(n.getScope().getEnclosingScope*(), n.getId())
enclosing_scope_defines_name(n.getScope(), n.getId())
or
// Defined as a built-in
n.getId() = Builtins::getBuiltinName()
@@ -35,10 +35,13 @@ module ImportStar {
n.getId() in ["__name__", "__package__"]
}
/** Holds if the name `name` is defined in the scope `s` */
pragma[nomagic]
private predicate scope_defines_name(Scope s, string name) {
exists(LocalVariable v | v.getId() = name and v.getScope() = s)
private predicate enclosing_scope_defines_name(Scope s, string name) {
exists(LocalVariable v |
v.getId() = name and v.getScope() = s and not name = Builtins::getBuiltinName()
)
or
enclosing_scope_defines_name(s.getEnclosingScope(), name)
}
/** Holds if a global variable called `name` is assigned a value in the module `m`. */