hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: reformulate CallToObjectDefineProperty::getAPropertyAttribute

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2019-04-08 12:25:58 +02:00
parent 662ad4b2ca
commit b86f43be98
3 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/Declarations/DeadStoreOfProperty.ql
View File

@@ -161,7 +161,7 @@ where
// exclude results from non-value definitions from `Object.defineProperty`
(
assign1 instanceof CallToObjectDefineProperty implies
assign1.(CallToObjectDefineProperty).getAPropertyAttribute().getPropertyName() = "value"
assign1.(CallToObjectDefineProperty).hasPropertyAttributeWrite("value", _)
)
select assign1.getWriteNode(),
"This write to property '" + name + "' is useless, since $@ always overrides it.",