From 3bcfbcdf686b2fe6abd74380747294e8d7a14994 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Tue, 15 Aug 2023 16:49:42 +0100 Subject: [PATCH] Don't warn when Go version exactly matches go.mod We had only previously tested this with e.g. installed go 1.20.5 >= go.mod request `go 1.20`; now we have go 1.21.0 which shouldn't elicit a warning because 1.21.0 is equal to the go.mod request `go 1.21`. --- go/extractor/cli/go-autobuilder/go-autobuilder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/extractor/cli/go-autobuilder/go-autobuilder.go b/go/extractor/cli/go-autobuilder/go-autobuilder.go index 3f065dc3597..35bd4dca731 100644 --- a/go/extractor/cli/go-autobuilder/go-autobuilder.go +++ b/go/extractor/cli/go-autobuilder/go-autobuilder.go @@ -773,7 +773,7 @@ func installDependenciesAndBuild() { goModVersion, goModVersionFound := tryReadGoDirective(buildInfo) - if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) >= 0 { + if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) > 0 { diagnostics.EmitNewerGoVersionNeeded() }