hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 13:45:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address code review comments

Browse Source 
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
This commit is contained in:
Alvaro Muñoz
2022-10-18 13:29:28 +02:00
parent 6ab62da015
commit b79f7f3e95
8 changed files with 164 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
javascript/ql/test/library-tests/frameworks/Spife/tests.ql
View File

@@ -33,6 +33,15 @@ query predicate passingPositiveTests(string res, string expectation, InlineTest
res = "PASSED" and
t.hasPositiveTest(expectation) and
(
expectation = "headerDefinition" and
exists(Http::HeaderDefinition n | t.inNode(n))
or
expectation = "cookieDefinition" and
exists(Http::CookieDefinition n | t.inNode(n))
or
expectation = "templateInstantiation" and
exists(Templating::TemplateInstantiation::Range n | t.inNode(n))
or
expectation = "source" and
exists(RemoteFlowSource n | t.inNode(n))
or
@@ -74,6 +83,15 @@ query predicate failingPositiveTests(string res, string expectation, InlineTest
res = "FAILED" and
t.hasPositiveTest(expectation) and
(
expectation = "headerDefinition" and
not exists(Http::HeaderDefinition n | t.inNode(n))
or
expectation = "cookieDefinition" and
not exists(Http::CookieDefinition n | t.inNode(n))
or
expectation = "templateInstantiation" and
not exists(Templating::TemplateInstantiation::Range n | t.inNode(n))
or
expectation = "source" and
not exists(RemoteFlowSource n | t.inNode(n))
or
@@ -115,6 +133,15 @@ query predicate passingNegativeTests(string res, string expectation, InlineTest
res = "PASSED" and
t.hasNegativeTest(expectation) and
(
expectation = "!headerDefinition" and
not exists(Http::HeaderDefinition n | t.inNode(n))
or
expectation = "!cookieDefinition" and
not exists(Http::CookieDefinition n | t.inNode(n))
or
expectation = "!templateInstantiation" and
not exists(Templating::TemplateInstantiation::Range n | t.inNode(n))
or
expectation = "!source" and
not exists(RemoteFlowSource n | t.inNode(n))
or
@@ -156,6 +183,15 @@ query predicate failingNegativeTests(string res, string expectation, InlineTest
res = "FAILED" and
t.hasNegativeTest(expectation) and
(
expectation = "!headerDefinition" and
exists(Http::HeaderDefinition n | t.inNode(n))
or
expectation = "!cookieDefinition" and
exists(Http::CookieDefinition n | t.inNode(n))
or
expectation = "!templateInstantiation" and
exists(Templating::TemplateInstantiation::Range n | t.inNode(n))
or
expectation = "!source" and
exists(RemoteFlowSource n | t.inNode(n))
or