hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #745 from hvitved/csharp/query/missed-readonly-modifier

Browse Source 
Approved by calumgrant
This commit is contained in:
semmle-qlci
2019-01-14 08:43:59 +00:00
committed by GitHub
parent 3fe9f92817 2197736128
commit b78fcd39be
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
csharp/ql/src/Language Abuse/MissedReadonlyOpportunity.ql
View File

@@ -12,8 +12,12 @@
import csharp
predicate defTargetsField(AssignableDefinition def, Field f) {
def.getTarget().getSourceDeclaration() = f
}
predicate isReadonlyCompatibleDefinition(AssignableDefinition def, Field f) {
def.getTarget().getSourceDeclaration() = f and
defTargetsField(def, f) and
(
def.getEnclosingCallable().(Constructor).getDeclaringType() = f.getDeclaringType()
or
@@ -22,7 +26,7 @@ predicate isReadonlyCompatibleDefinition(AssignableDefinition def, Field f) {
}
predicate canBeReadonly(Field f) {
forex(AssignableDefinition def | def.getTarget().getSourceDeclaration() = f |
forex(AssignableDefinition def | defTargetsField(def, f) |
isReadonlyCompatibleDefinition(def, f)
)
}