From b6951d82497c4b15ac67816e3303be5f5f73efa3 Mon Sep 17 00:00:00 2001 From: Esben Sparre Andreasen Date: Mon, 6 Aug 2018 15:10:35 +0200 Subject: [PATCH] JS: add tests for improved js/missing-rate-limiting --- .../query-tests/Security/CWE-770/MissingRateLimiting.expected | 1 + javascript/ql/test/query-tests/Security/CWE-770/tst.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimiting.expected b/javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimiting.expected index a2f43fe540b..560be8bbb86 100644 --- a/javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimiting.expected +++ b/javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimiting.expected @@ -6,3 +6,4 @@ | tst.js:36:20:36:36 | expensiveHandler2 | This route handler performs $@, but is not rate-limited. | tst.js:15:40:15:73 | fs.writ ... quest") | a file system access | | tst.js:37:20:37:36 | expensiveHandler3 | This route handler performs $@, but is not rate-limited. | tst.js:16:40:16:70 | child_p ... /true") | a system command | | tst.js:38:20:38:36 | expensiveHandler4 | This route handler performs $@, but is not rate-limited. | tst.js:17:40:17:83 | connect ... ution') | a database access | +| tst.js:64:25:64:63 | functio ... req); } | This route handler performs $@, but is not rate-limited. | tst.js:64:46:64:60 | verifyUser(req) | authorization | diff --git a/javascript/ql/test/query-tests/Security/CWE-770/tst.js b/javascript/ql/test/query-tests/Security/CWE-770/tst.js index bb06fe9a87d..f38a9e83aa2 100644 --- a/javascript/ql/test/query-tests/Security/CWE-770/tst.js +++ b/javascript/ql/test/query-tests/Security/CWE-770/tst.js @@ -60,3 +60,6 @@ app2.get('/:path', bruteforce.prevent, expensiveHandler1); // OK var app3 = express(); var limiter = require('express-limiter')(app3); app3.get('/:path', expensiveHandler1); // OK + +express().get('/:path', function(req, res) { verifyUser(req); }); // NOT OK +express().get('/:path', RateLimit(), function(req, res) { verifyUser(req); }); // OK