hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove flow states, remove string as sources

Browse Source
This commit is contained in:
am0o0
2024-07-28 11:26:18 +02:00
parent 46ddddc8cf
commit b5e7716579
1 changed files with 11 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
java/ql/src/experimental/Security/CWE/CWE-347/Auth0NoVerifier.ql
View File

@@ -57,73 +57,40 @@ module JwtAuth0 {
}
}
module JwtDecodeConfig implements DataFlow::StateConfigSig {
class FlowState = DataFlow::FlowState;
predicate isSource(DataFlow::Node source, FlowState state) {
(
exists(Variable v |
source.asExpr() = v.getInitializer() and
v.getType().hasName("String")
)
or
source instanceof RemoteFlowSource
) and
not FlowToJwtVerify::flow(source, _) and
state = "Auth0" and
not state = "Auth0Verify"
module JwtDecodeConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) {
source instanceof RemoteFlowSource and
not FlowToJwtVerify::flow(source, _)
}
predicate isSink(DataFlow::Node sink, FlowState state) {
sink.asExpr() = any(JwtAuth0::GetPayload a) and
state = "Auth0" and
not state = "Auth0Verify"
}
predicate isSink(DataFlow::Node sink) { sink.asExpr() = any(JwtAuth0::GetPayload a) }
predicate isAdditionalFlowStep(
DataFlow::Node nodeFrom, FlowState stateFrom, DataFlow::Node nodeTo, FlowState stateTo
) {
predicate isAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
// Decode Should be one of the middle nodes
exists(JwtAuth0::Decode a |
nodeFrom.asExpr() = a.getArgument(0) and
nodeTo.asExpr() = a and
stateTo = "Auth0" and
stateFrom = "Auth0"
nodeTo.asExpr() = a
)
or
exists(JwtAuth0::Verify a |
nodeFrom.asExpr() = a.getArgument(0) and
nodeTo.asExpr() = a and
stateTo = "Auth0Verify" and
stateFrom = "Auth0Verify"
nodeTo.asExpr() = a
)
or
exists(JwtAuth0::GetPayload a |
nodeFrom.asExpr() = a.getQualifier() and
nodeTo.asExpr() = a and
stateTo = "Auth0" and
stateFrom = "Auth0"
nodeTo.asExpr() = a
)
}
predicate isBarrier(DataFlow::Node sanitizer, FlowState state) { none() }
}
module FlowToJwtVerifyConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) {
// source instanceof DataFlow::Node
exists(Variable v |
source.asExpr() = v.getInitializer() and
v.getType().hasName("String")
)
}
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
predicate isSink(DataFlow::Node sink) { sink.asExpr() = any(JwtAuth0::Verify a).getArgument(0) }
predicate isAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) { none() }
}
module JwtDecode = TaintTracking::GlobalWithState<JwtDecodeConfig>;
module JwtDecode = TaintTracking::Global<JwtDecodeConfig>;
module FlowToJwtVerify = TaintTracking::Global<FlowToJwtVerifyConfig>;