QL code and tests for C#/C++/JavaScript.

javascript/ql/src/Statements/examples/DanglingElse.js

@@ -0,0 +1,8 @@
+function f() {
+	if (cond1())
+		if (cond2())
+			return 23;
+	else
+		return 42;
+	return 56;
+}

javascript/ql/src/Statements/examples/DanglingElseGood.js

@@ -0,0 +1,8 @@
+function f() {
+	if (cond1())
+		if (cond2())
+			return 23;
+		else
+			return 42;
+	return 56;
+}

javascript/ql/src/Statements/examples/DanglingElseGood2.js

@@ -0,0 +1,10 @@
+function f() {
+	if (cond1()) {
+		if (cond2()) {
+			return 23;
+		} else {
+			return 42;
+		}
+	}
+	return 56;
+}

javascript/ql/src/Statements/examples/EphemeralLoop.js

@@ -0,0 +1,24 @@
+function nextToken(reader){
+  var c = reader.read(), token = null;
+
+  while (c) {
+    switch(c) {
+    case "/":
+      if(reader.peek() == "*")
+        token = commentToken(reader, c, startLine, startCol);
+      else
+        token = charToken(reader, c, startLine, startCol);
+      break;
+    case '"':
+    case "'":
+      token = stringToken(c, startLine, startCol);
+      break;
+    default:
+      token = charToken(reader, c, startLine, startCol);
+    }
+
+    break;
+  }
+
+  return token;
+}

javascript/ql/src/Statements/examples/EphemeralLoopGood.js

@@ -0,0 +1,22 @@
+function nextToken(reader){
+  var c = reader.read(), token = null;
+
+  if (c) {
+    switch(c) {
+    case "/":
+      if(reader.peek() == "*")
+        token = commentToken(reader, c, startLine, startCol);
+      else
+        token = charToken(reader, c, startLine, startCol);
+      break;
+    case '"':
+    case "'":
+      token = stringToken(c, startLine, startCol);
+      break;
+    default:
+      token = charToken(reader, c, startLine, startCol);
+    }
+  }
+
+  return token;
+}

javascript/ql/src/Statements/examples/ImplicitReturn.js

@@ -0,0 +1,4 @@
+function call(o, m) {
+	if (o && typeof o[m] === 'function')
+		return o[m]();
+}

javascript/ql/src/Statements/examples/ImplicitReturnGood.js

@@ -0,0 +1,5 @@
+function call(o, m) {
+	if (o && typeof o[m] === 'function')
+		return o[m]();
+	throw new Error("no such method");
+}

javascript/ql/src/Statements/examples/InconsistentLoopOrientation.js

@@ -0,0 +1,7 @@
+// zero out everything below index `lower`
+for (i=lower-1; i>=0; --i)
+    a[i] = 0;
+
+// zero out everything above index `upper`
+for (i=upper+1; i<a.length; --i)
+    a[i] = 0;

javascript/ql/src/Statements/examples/InconsistentLoopOrientationGood.js

@@ -0,0 +1,7 @@
+// zero out everything below index `lower`
+for (i=lower-1; i>=0; --i)
+    a[i] = 0;
+
+// zero out everything above index `upper`
+for (i=upper+1; i<a.length; ++i)
+    a[i] = 0;

javascript/ql/src/Statements/examples/InconsistentReturn.js

@@ -0,0 +1,5 @@
+function solve_quad(a, b, c) {
+	if (a === 0 || b*b < 4*a*c)
+		return;
+	return (-b + Math.sqrt(b*b - 4*a*c))/(2*a);
+}

javascript/ql/src/Statements/examples/InconsistentReturnGood.js

@@ -0,0 +1,5 @@
+function solve_quad(a, b, c) {
+	if (a === 0 || b*b < 4*a*c)
+		return void 0;
+	return (-b + Math.sqrt(b*b - 4*a*c))/(2*a);
+}

javascript/ql/src/Statements/examples/LabelInCase.js

@@ -0,0 +1,10 @@
+function f(x) {
+	switch (x) {
+	case 1:
+	case 2:
+	case3:
+		return true;
+	default:
+		return false;
+	}
+}

javascript/ql/src/Statements/examples/MisleadingIndentationAfterControlStmt.js

@@ -0,0 +1,3 @@
+if (afraid())
+	scream();
+	runAway();

javascript/ql/src/Statements/examples/MisleadingIndentationAfterControlStmtGood.js

@@ -0,0 +1,4 @@
+if (afraid()) {
+	scream();
+	runAway();
+}

javascript/ql/src/Statements/examples/MisleadingIndentationAfterControlStmtGood2.js

@@ -0,0 +1,3 @@
+if (afraid())
+	scream();
+runAway();

javascript/ql/src/Statements/examples/NestedLoopsSameVariable.js

@@ -0,0 +1,5 @@
+for (var i=0; i<10; ++i) {
+	// NOT OK
+	for (var j=i; i>5; --i)
+		f(i, j);
+}

javascript/ql/src/Statements/examples/NestedLoopsSameVariableGood.js

@@ -0,0 +1,5 @@
+for (var i=0; i<10; ++i) {
+	// NOT OK
+	for (var j=i; j>5; --j)
+		f(i, j);
+}

javascript/ql/src/Statements/examples/ReturnAssignsLocal.js

@@ -0,0 +1,10 @@
+function Person(first, last, age) {
+	this.first = first;
+	this.last = last;
+	this.age = age;
+}
+
+Person.prototype.getName = function() {
+	var name = first + " " + last;
+	return name = name.trim();
+};

javascript/ql/src/Statements/examples/ReturnAssignsLocalGood.js

@@ -0,0 +1,10 @@
+function Person(first, last, age) {
+	this.first = first;
+	this.last = last;
+	this.age = age;
+}
+
+Person.prototype.getName = function() {
+	var name = first + " " + last;
+	return name.trim();
+};

javascript/ql/src/Statements/examples/ReturnOutsideFunction.htm

@@ -0,0 +1,3 @@
+<form name="f" action="javascript:return validateForm(this);" method="post">
+    <!--  form contents -->
+</form>

javascript/ql/src/Statements/examples/ReturnOutsideFunctionGood.htm

@@ -0,0 +1,3 @@
+<form name="f" onsubmit="return validateForm(this);" method="post">
+    <!--  form contents -->
+</form>

javascript/ql/src/Statements/examples/SuspiciousUnusedLoopIterationVariable.js

@@ -0,0 +1,7 @@
+function countOccurrences(xs, p) {
+	var count = 0;
+	for (let x of xs)
+		if (p())
+			++count;
+	return count;
+}

javascript/ql/src/Statements/examples/UnreachableStatement.js

@@ -0,0 +1,5 @@
+function f() {
+	if (someCond());
+		return 23;
+	return 42;
+}

javascript/ql/src/Statements/examples/UnreachableStatementGood.js

@@ -0,0 +1,5 @@
+function f() {
+	if (someCond())
+		return 23;
+	return 42;
+}

javascript/ql/src/Statements/examples/UselessConditional.js

@@ -0,0 +1,8 @@
+function getLastLine(input) {
+  var lines = [], nextLine;
+  while ((nextLine = readNextLine(input)))
+    lines.push(nextLine);
+  if (!lines)
+    throw new Error("No lines!");
+  return lines[lines.length-1];
+}

javascript/ql/src/Statements/examples/UselessConditionalGood.js

@@ -0,0 +1,8 @@
+function getLastLine(input) {
+  var lines = [], nextLine;
+  while ((nextLine = readNextLine(input)))
+    lines.push(nextLine);
+  if (!lines.length)
+    throw new Error("No lines!");
+  return lines[lines.length-1];
+}