hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: add consistency exclusions

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2023-11-29 20:58:20 +01:00
parent c054ba6a97
commit b513871b9b
2 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
python/ql/consistency-queries/DataFlowConsistency.ql
View File

@@ -44,6 +44,24 @@ private module Input implements InputSig<PythonDataFlow> {
)
}
predicate uniqueEnclosingCallableExclude(Node n) {
// `CaptureNode`s miss enclosing calables in some cases.
exists(Function func |
func = n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable()
|
// This can happen if `func` is a comprehension.
// In that case, there is no associated DataFlowCallable.
not exists(func.getDefinition())
or
func.getADecorator().(Name).getId() = "property"
)
or
// We only have a selection of valid callables.
// For instance, we do not have classes as `DataFlowCallable`s.
not n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable() instanceof Function and
not n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable() instanceof Module
}
predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) {
not exists(call.getLocation().getFile().getRelativePath())
}

14
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll
View File

@@ -40,6 +40,20 @@ private module Input implements InputSig<PythonDataFlow> {
)
}
predicate uniqueEnclosingCallableExclude(Node n) {
// `CaptureNode`s miss enclosing calables in some cases.
exists(Function func |
func = n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable()
|
// This can happen if `func` is a comprehension.
// In that case, there is no associated DataFlowCallable.
not exists(func.getDefinition())
)
or
// We do not have classes as `DataFlowCallable`s.
n.(CaptureNode).getSynthesizedCaptureNode().getEnclosingCallable() instanceof Class
}
predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) {
not exists(call.getLocation().getFile().getRelativePath())
}