hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Element.hasChildElement: associate local classes specialisations with their unspecialised containing function

Browse Source
This commit is contained in:
Chris Smowton
2022-10-12 15:30:48 +01:00
parent baaa06391c
commit b4c4a26e22
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/lib/semmle/code/java/Element.qll
View File

@@ -82,7 +82,15 @@ private predicate hasChildElement(Element parent, Element e) {
enclInReftype(e, parent) and
not e instanceof LocalClassOrInterface
or
e.(LocalClassOrInterface).getLocalTypeDeclStmt().getEnclosingCallable() = parent
// Reasoning: any specialised instance of a local class is supposed to belong to the general
// case of its enclosing method because we don't instantiate specialised variants of either generic
// functions or function bodies, and therefore the local class cannot be specialised with respect
// to its enclosing reftypes.
e.(LocalClassOrInterface)
.getSourceDeclaration()
.(LocalClassOrInterface)
.getLocalTypeDeclStmt()
.getEnclosingCallable() = parent
or
not enclInReftype(e, _) and
e.(Class).getCompilationUnit() = parent