From b4846dc99579843589757db84ad178ed1129c8ce Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Wed, 21 Nov 2018 13:11:08 +0000 Subject: [PATCH] CPP: Modify NVIHub.ql. --- cpp/ql/src/Best Practices/NVIHub.ql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/ql/src/Best Practices/NVIHub.ql b/cpp/ql/src/Best Practices/NVIHub.ql index 8f87c89809a..a5e67a2cbee 100644 --- a/cpp/ql/src/Best Practices/NVIHub.ql +++ b/cpp/ql/src/Best Practices/NVIHub.ql @@ -4,7 +4,7 @@ * to enforce invariants that should hold for the whole hierarchy. * This is especially problematic in classes with many * dependencies or dependents. - * @kind table + * @kind problem * @id cpp/nvi-hub * @problem.severity recommendation * @precision low @@ -22,4 +22,4 @@ where f.hasSpecifier("public") and fclass = f.getDeclaringType() and hubIndex = fclass.getMetrics().getAfferentCoupling() * fclass.getMetrics().getEfferentCoupling() and hubIndex > 100 -select f.getFile(), f, "Avoid having public virtual methods (NVI idiom)" +select f, "Avoid having public virtual methods (NVI idiom)"