From 8492f6031fc040537ce004696b5560b34d054eed Mon Sep 17 00:00:00 2001
From: Erik Krogh Kristensen <erik-krogh@github.com>
Date: Fri, 24 Jan 2020 13:36:32 +0100
Subject: [PATCH] reuse existing type-tracking for classes

---
 .../src/semmle/javascript/frameworks/NodeJSLib.qll  | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll b/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
index 11d6990cd9c..27fc6216253 100644
--- a/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
+++ b/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
@@ -919,17 +919,6 @@ module NodeJSLib {
       this.getASuperClassNode().getALocalSource() = getAnEventEmitterImport() or
       this.getADirectSuperClass() instanceof EventEmitterSubClass
     }
-
-    private DataFlow::SourceNode ref(DataFlow::TypeTracker t) {
-      t.start() and result = this
-      or
-      exists (DataFlow::TypeTracker t2 | result = ref(t2).track(t2, t))
-    }
-
-    /**
-     * Gets a reference to this class.
-     */
-    DataFlow::SourceNode ref() { result = ref(DataFlow::TypeTracker::end()) }
   }
 
   /**
@@ -939,7 +928,7 @@ module NodeJSLib {
    */
   private class CustomEventEmitter extends NodeJSEventEmitter {
     CustomEventEmitter() {
-      this = any(EventEmitterSubClass clazz).ref().getAnInstantiation()
+      this = any(EventEmitterSubClass clazz).getAClassReference().getAnInstantiation()
     }
   }