hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-20 22:44:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix violations

Browse Source
This commit is contained in:
Calum Grant
2019-08-23 12:10:03 +01:00
parent 97522c506e
commit b3d5e405a6
3 changed files with 7 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/extractor/Semmle.Extraction.CIL/Factories.cs
View File

@@ -56,7 +56,7 @@ namespace Semmle.Extraction.CIL
}
#if DEBUG_LABELS
Dictionary<string, ILabelledEntity> debugLabels = new Dictionary<string, ILabelledEntity>();
private readonly Dictionary<string, ILabelledEntity> debugLabels = new Dictionary<string, ILabelledEntity>();
#endif
public IExtractedEntity Create(Handle h)
@@ -66,7 +66,7 @@ namespace Semmle.Extraction.CIL
}
// Lazily cache primitive types.
PrimitiveType[] primitiveTypes = new PrimitiveType[(int)PrimitiveTypeCode.Object + 1];
private readonly PrimitiveType[] primitiveTypes = new PrimitiveType[(int)PrimitiveTypeCode.Object + 1];
public PrimitiveType Create(PrimitiveTypeCode code)
{

8
csharp/extractor/Semmle.Extraction/FreshEntity.cs
View File

@@ -43,9 +43,11 @@ namespace Semmle.Extraction
{
get
{
var writer = new StringWriter();
Populate(writer);
return writer.ToString();
using (var writer = new StringWriter())
{
Populate(writer);
return writer.ToString();
}
}
}

28
csharp/extractor/Semmle.Extraction/Id.cs
View File

@@ -103,34 +103,6 @@ namespace Semmle.Extraction
tb.Write(TrapBuilder.ToString());
tb.Write("\"");
}
class IdTrapBuilder
{
public readonly List<string> Fragments = new List<string>();
public void Append(object arg)
{
if (arg is IEntity)
{
var key = ((IEntity)arg).Label;
Fragments.Add("{#");
Fragments.Add(key.Value.ToString());
Fragments.Add("}");
}
else
Fragments.Add(arg.ToString());
}
public void Append(string arg)
{
Fragments.Add(arg);
}
public void AppendLine()
{
throw new NotImplementedException();
}
}
}
/// <summary>