hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Update comment in the char pred of 'GuardConditionFromNotExpr'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2025-01-17 12:17:47 +00:00
parent d5b31eb98c
commit b39a932ae1
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
View File

@@ -251,20 +251,11 @@ private class GuardConditionFromNotExpr extends GuardConditionImpl {
IRGuardCondition ir;
GuardConditionFromNotExpr() {
// When `!` is applied to an integer (such as `x`) the generated IR looks
// like:
// ```
// r1(glval<int>) = VariableAddress[myInt] :
// r2(int) = Load[x] : &:r1, m1_6
// r3(int) = Constant[0] :
// r4(bool) = CompareEQ : r2, r3
// ```
// And so the `IRGuardCondition` for an expression such as `if(!x)` is the
// `CompareEQ` instruction. However, users often expect the `x` to also
// be a guard condition. But from the perspective of the IR the `x` is just
// the left-hand side of a comparison against 0 so it's not included as a
// normal `IRGuardCondition`. So to align with user expectations we make
// that `x` a `GuardCondition`.
// Users often expect the `x` in `!x` to also be a guard condition. But
// from the perspective of the IR the `x` is just the left-hand side of a
// comparison against 0 so it's not included as a normal
// `IRGuardCondition`. So to align with user expectations we make that `x`
// a `GuardCondition`.
exists(NotExpr notExpr, Type t |
this = notExpr.getOperand() and
t = this.getUnspecifiedType() and