From b3631545d4c4bd37b07cd7058b4cb4a2db04ec12 Mon Sep 17 00:00:00 2001 From: Mathias Vorreiter Pedersen Date: Mon, 19 Jan 2026 11:57:45 +0000 Subject: [PATCH] C++: Delete unnecessary conjuncts after review comments. --- .../cpp/ir/implementation/raw/internal/TranslatedAssertion.qll | 3 --- 1 file changed, 3 deletions(-) diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedAssertion.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedAssertion.qll index 0097428a1fc..0eebcf60951 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedAssertion.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedAssertion.qll @@ -89,13 +89,11 @@ private predicate parseArgument(string arg, string s, int i, Opcode opcode) { i + 1) and opcode instanceof Opcode::CompareGE or - not arg.regexpMatch("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?<=\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)") and s = arg.regexpCapture("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?<\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)", i + 1) and opcode instanceof Opcode::CompareLT or - not arg.regexpMatch("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?>=\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)") and s = arg.regexpCapture("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?>\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)", i + 1) and @@ -127,7 +125,6 @@ private predicate hasVarAccessMacroArgument(MacroInvocation mi, Variable var, in exists(string arg, string s, Function f | arg = mi.getUnexpandedArgument(0) and f = getEnclosingFunctionForMacroInvocation(mi) and - not exists(s.toInt()) and parseArgument(arg, s, i, opcode) and var = unique( | | getAVariableWithNameInFunction(f, s)) )