From b3285c6ae2274aaa456a2fe152945f38bd16f8af Mon Sep 17 00:00:00 2001
From: Owen Mansel-Chan <owen-mc@github.com>
Date: Fri, 27 Mar 2026 11:35:22 +0000
Subject: [PATCH] Make description of `acceptingvalue` column clearer

---
 cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll         | 5 ++---
 .../semmle/code/csharp/dataflow/internal/ExternalFlow.qll    | 4 ++--
 go/ql/lib/semmle/go/dataflow/ExternalFlow.qll                | 5 ++---
 java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll       | 4 ++--
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
index ed40d391917..3fe9f6aaedf 100644
--- a/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
+++ b/cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
@@ -91,9 +91,8 @@
  *    - flow from the _second_ indirection of the 0th argument to the first
  *    indirection of the return value, etc.
  * 8. The `acceptingvalue` column of barrier guard models specifies the condition
- *    under which the guard accepts or blocks flow. It can be one of "true" or
- *    "false". In the future "no-exception", "not-zero", "null", "not-null" may be
- *    supported.
+ *    under which the guard blocks flow. It can be one of "true" or "false". In
+ *    the future "no-exception", "not-zero", "null", "not-null" may be supported.
  * 9. The `kind` column is a tag that can be referenced from QL to determine to
  *    which classes the interpreted elements should be added. For example, for
  *    sources "remote" indicates a default remote flow source, and for summaries
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll
index 95b9578e4f3..17cdcc1bf0b 100644
--- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll
+++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll
@@ -74,8 +74,8 @@
  *    - "Property[p]": Selects the contents of property `p`.
  *
  * 8. The `acceptingvalue` column of barrier guard models specifies the condition
- *    under which the guard accepts or blocks flow. It can be one of "true" or
- *    "false", "no-exception", "not-zero", "null", "not-null".
+ *    under which the guard blocks flow. It can be one of "true" or "false". In
+ *    the future "no-exception", "not-zero", "null", "not-null" may be supported.
  * 9. The `kind` column is a tag that can be referenced from QL to determine to
  *    which classes the interpreted elements should be added. For example, for
  *    sources "remote" indicates a default remote flow source, and for summaries
diff --git a/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll b/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll
index 05379c620fb..0ad28bac533 100644
--- a/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll
+++ b/go/ql/lib/semmle/go/dataflow/ExternalFlow.qll
@@ -83,9 +83,8 @@
  *    - "Dereference": Selects the value referenced by a pointer.
  *
  * 8. The `acceptingvalue` column of barrier guard models specifies the condition
- *    under which the guard accepts or blocks flow. It can be one of "true" or
- *    "false". In the future "no-exception", "not-zero", "null", "not-null" may be
- *    supported.
+ *    under which the guard blocks flow. It can be one of "true" or "false". In
+ *    the future "no-exception", "not-zero", "null", "not-null" may be supported.
  * 9. The `kind` column is a tag that can be referenced from QL to determine to
  *    which classes the interpreted elements should be added. For example, for
  *    sources "remote" indicates a default remote flow source, and for summaries
diff --git a/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll b/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
index 8f6d1a7855a..6ad4a5938a3 100644
--- a/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
+++ b/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
@@ -74,8 +74,8 @@
  *    - "ReturnValue": Selects the return value of a call to the selected element.
  *    - "Element": Selects the collection elements of the selected element.
  * 8. The `acceptingvalue` column of barrier guard models specifies the condition
- *    under which the guard accepts or blocks flow. It can be one of "true" or
- *    "false", "no-exception", "not-zero", "null", "not-null".
+ *    under which the guard blocks flow. It can be one of "true" or "false". In
+ *    the future "no-exception", "not-zero", "null", "not-null" may be supported.
  * 9. The `kind` column is a tag that can be referenced from QL to determine to
  *    which classes the interpreted elements should be added. For example, for
  *    sources "remote" indicates a default remote flow source, and for summaries