hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: start handling iterated unpacking

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2021-01-13 08:40:47 +01:00
parent 4ee2f49f38
commit b10cf78e17
3 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
python/ql/src/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -126,6 +126,15 @@ module EssaFlow {
nodeFrom.(CfgNode).getNode() =
nodeTo.(EssaNode).getVar().getDefinition().(AssignmentDefinition).getValue()
or
// Definition
// `a, b = iterable`
// nodeFrom = `iterable`, cfg node
// nodeTo = `a, b`, cfg node
exists(Assign assign, SequenceNode target | target.getNode() = assign.getATarget() |
nodeFrom.asExpr() = assign.getValue() and
nodeTo.asCfgNode() = target
)
or
// With definition
// `with f(42) as x:`
// nodeFrom is `f(42)`, cfg node
@@ -1104,12 +1113,13 @@ module unpackinAssignment {
}
predicate unpackingAssignmentDirectFlowStep(CfgNode nodeFrom, CfgNode nodeTo) {
// `a, b = iterable`
// nodeFrom = `iterable`
// readNode = `a, b`
// `a, *b = iterable`
// nodeFrom = `a, b`
// nodeTo = `*b`
exists(Assign assign, SequenceNode target | target.getNode() = assign.getATarget() |
nodeFrom.asExpr() = assign.getValue() and
nodeTo.getNode() = target
nodeFrom.getNode() = target and
nodeTo.getNode() = target.getAnElement() and
nodeTo.asExpr() instanceof Starred
)
}