hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Adjust tag format

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2020-10-14 09:51:24 +02:00
parent 93383747bd
commit b0ebb5b6d1
4 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/ql/test/experimental/library-tests/frameworks/dill/Decoding.py
View File

@@ -1,4 +1,4 @@
import dill
dill.loads(payload) # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=dill
dill.loads(payload, encoding='latin1') # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=dill
dill.loads(payload) # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=dill $decodeUnsafe=
dill.loads(payload, encoding='latin1') # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=dill $decodeUnsafe=

6
python/ql/test/experimental/library-tests/frameworks/stdlib/Decoding.py
View File

@@ -10,6 +10,6 @@ app = Flask(__name__)
@app.route("/")
def hello():
payload = request.args.get("payload")
pickle.loads(payload) # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=pickle
pickle.loads(payload, encoding='latin1') # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=pickle
marshal.loads(payload) # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=marshal
pickle.loads(payload) # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=pickle $decodeUnsafe=
pickle.loads(payload, encoding='latin1') # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=pickle $decodeUnsafe=
marshal.loads(payload) # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=pickle $decodeUnsafe=

4
python/ql/test/experimental/library-tests/frameworks/yaml/Decoding.py
View File

@@ -10,5 +10,5 @@ app = Flask(__name__)
@app.route("/")
def hello():
payload = request.args.get("payload")
yaml.load(payload) # $UNSAFE_getAnInput=payload $UNSAFE_getOutput=Attribute() $UNSAFE_getFormat=YAML
yaml.load(payload, Loader=SafeLoader) # $getAnInput=payload $getOutput=Attribute() $getFormat=YAML
yaml.load(payload) # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=YAML $decodeUnsafe=
yaml.load(payload, Loader=SafeLoader) # $decodeInput=payload $decodeOutput=Attribute() $decodeFormat=YAML

23
python/ql/test/experimental/meta/ConceptsTest.qll
View File

@@ -36,16 +36,13 @@ class SystemCommandExecutionTest extends InlineExpectationsTest {
class DecodingTest extends InlineExpectationsTest {
DecodingTest() { this = "DecodingTest" }
override string getARelevantTag() { result in ["getAnInput", "getOutput", "getFormat"] }
override string getARelevantTag() {
result in ["decodeInput", "decodeOutput", "decodeFormat", "decodeUnsafe"]
}
override predicate hasActualResult(Location location, string element, string tag, string value) {
exists(location.getFile().getRelativePath()) and
exists(Decoding d, string unsafe |
(
d.unsafe() and unsafe = "UNSAFE_"
or
not d.unsafe() and unsafe = ""
) and
exists(Decoding d |
(
exists(DataFlow::Node data |
location = data.getLocation() and
@@ -53,10 +50,10 @@ class DecodingTest extends InlineExpectationsTest {
value = value_from_expr(data.asExpr()) and
(
data = d.getAnInput() and
tag = unsafe + "getAnInput"
tag = "decodeInput"
or
data = d.getOutput() and
tag = unsafe + "getOutput"
tag = "decodeOutput"
)
)
or
@@ -65,8 +62,14 @@ class DecodingTest extends InlineExpectationsTest {
element = format and
value = format and
format = d.getFormat() and
tag = unsafe + "getFormat"
tag = "decodeFormat"
)
or
d.unsafe() and
location = d.getLocation() and
element = d.toString() and
value = "" and
tag = "decodeUnsafe"
)
)
}