hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Suppress more spurious alerts from ExternalAPI queries

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2022-08-16 15:45:02 +02:00
parent 70cc986d5f
commit af9be6ad7e
1 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
python/ql/src/Security/CWE-020-ExternalAPIs/ExternalAPIs.qll
View File

@@ -39,7 +39,11 @@ deprecated class SafeExternalAPI = SafeExternalApi;
/** The default set of "safe" external APIs. */ /** The default set of "safe" external APIs. */
private class DefaultSafeExternalApi extends SafeExternalApi { private class DefaultSafeExternalApi extends SafeExternalApi {
override DataFlow::CallCfgNode getSafeCall() { override DataFlow::CallCfgNode getSafeCall() {
result = API::builtin(["len", "isinstance", "getattr", "hasattr"]).getACall() result =
API::builtin([
"len", "enumerate", "isinstance", "getattr", "hasattr", "bool", "float", "int", "repr",
"str", "type"
]).getACall()
} }
} }
@@ -57,28 +61,40 @@ string apiNodeToStringRepr(API::Node node) {
exists(API::Node base, string basename | exists(API::Node base, string basename |
base.getDepth() < node.getDepth() and base.getDepth() < node.getDepth() and
basename = apiNodeToStringRepr(base) and basename = apiNodeToStringRepr(base) and
not base = API::builtin("None") not base = API::builtin(["None", "True", "False"])
| |
exists(string m | node = base.getMember(m) | result = basename + "." + m) exists(string m | node = base.getMember(m) | result = basename + "." + m)
or or
node = base.getReturn() and node = base.getReturn() and
result = basename + "()" result = basename + "()" and
not base.getACall() = any(SafeExternalApi safe).getSafeCall()
or or
node = base.getAwaited() and node = base.getAwaited() and
result = basename result = basename
) )
} }
predicate resolvedCall(CallNode call) {
DataFlowPrivate::resolveCall(call, _, _) or
DataFlowPrivate::resolveClassCall(call, _)
}
newtype TInterestingExternalApiCall = newtype TInterestingExternalApiCall =
TUnresolvedCall(DataFlow::CallCfgNode call) { TUnresolvedCall(DataFlow::CallCfgNode call) {
exists(call.getLocation().getFile().getRelativePath()) and exists(call.getLocation().getFile().getRelativePath()) and
not exists(DataFlowPrivate::DataFlowCall dfCall | dfCall.getNode() = call.getNode()) and not resolvedCall(call.getNode()) and
not call = any(SafeExternalApi safe).getSafeCall() not call = any(SafeExternalApi safe).getSafeCall()
} or } or
TResolvedCall(DataFlowPrivate::DataFlowCall call) { TResolvedCall(DataFlowPrivate::DataFlowCall call) {
exists(call.getLocation().getFile().getRelativePath()) and exists(call.getLocation().getFile().getRelativePath()) and
not call.getCallable() = any(SafeExternalApi safe).getSafeCallable() and not call.getCallable() = any(SafeExternalApi safe).getSafeCallable() and
not exists(call.getCallable().getLocation().getFile().getRelativePath()) // ignore calls inside codebase, and ignore calls that are marked as safe. This is
// only needed as long as we extract dependencies. When we stop doing that, all
// targets of resolved calls will be from user-written code.
not exists(call.getCallable().getLocation().getFile().getRelativePath()) and
not exists(DataFlow::CallCfgNode callCfgNode | callCfgNode.getNode() = call.getNode() |
any(SafeExternalApi safe).getSafeCall() = callCfgNode
)
} }
abstract class InterestingExternalApiCall extends TInterestingExternalApiCall { abstract class InterestingExternalApiCall extends TInterestingExternalApiCall {
@@ -103,7 +119,9 @@ class ResolvedCall extends InterestingExternalApiCall, TResolvedCall {
result = dfCall.getArgument(apos) result = dfCall.getArgument(apos)
} }
override string toString() { result = "ExternalAPI:ResolvedCall" } override string toString() {
result = "ExternalAPI:ResolvedCall: " + dfCall.getNode().getNode().toString()
}
override string getApiName() { override string getApiName() {
exists(DataFlow::CallCfgNode call, API::Node apiNode | dfCall.getNode() = call.getNode() | exists(DataFlow::CallCfgNode call, API::Node apiNode | dfCall.getNode() = call.getNode() |
@@ -124,7 +142,9 @@ class UnresolvedCall extends InterestingExternalApiCall, TUnresolvedCall {
exists(string name | apos.isKeyword(name) | result = call.getArgByName(name)) exists(string name | apos.isKeyword(name) | result = call.getArgByName(name))
} }
override string toString() { result = "ExternalAPI:UnresolvedCall" } override string toString() {
result = "ExternalAPI:UnresolvedCall: " + call.getNode().getNode().toString()
}
override string getApiName() { override string getApiName() {
exists(API::Node apiNode | exists(API::Node apiNode |