hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Apply suggestions from code review

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
This commit is contained in:
Taus
2021-04-16 11:35:12 +02:00
committed by GitHub
parent 7f131c1f35
commit af0c32c01d
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/ql/src/semmle/python/frameworks/Fabric.qll
View File

@@ -83,7 +83,9 @@ private module FabricV2 {
module Connection {
/** Gets a reference to the `fabric.connection.Connection` class. */
API::Node classRef() {
result in [fabric().getMember("Connection"), connection().getMember("Connection")]
result = fabric().getMember("Connection")
or
result = connection().getMember("Connection")
}
/**
@@ -110,7 +112,7 @@ private module FabricV2 {
}
/** Gets a reference to an instance of `fabric.connection.Connection`. */
DataFlow::LocalSourceNode instance() { result = instance(DataFlow::TypeTracker::end()) }
DataFlow::Node instance() { instance(DataFlow::TypeTracker::end()).flowsTo(result) }
/**
* Gets a reference to either `run`, `sudo`, or `local` method on a
@@ -249,7 +251,9 @@ private module FabricV2 {
module SerialGroup {
private class ClassInstantiation extends Group::ModeledSubclass {
ClassInstantiation() {
this in [group().getMember("SerialGroup"), fabric().getMember("SerialGroup")]
this = group().getMember("SerialGroup")
or
this = fabric().getMember("SerialGroup")
}
}
}
@@ -262,7 +266,9 @@ private module FabricV2 {
module ThreadingGroup {
private class ClassInstantiation extends Group::ModeledSubclass {
ClassInstantiation() {
this in [group().getMember("ThreadingGroup"), fabric().getMember("ThreadingGroup")]
this = group().getMember("ThreadingGroup")
or
this = fabric().getMember("ThreadingGroup")
}
}
}