hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix LGTM warnings

Browse Source
This commit is contained in:
Calum Grant
2019-05-20 12:04:05 +01:00
parent 55b41cfaf7
commit aecc9e2a57
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/VariableDeclaration.cs
View File

@@ -75,7 +75,6 @@ namespace Semmle.Extraction.CSharp.Entities.Expressions
{
var decl = Create(cx, variable, Type.Create(cx, local.Type), true, tuple, child0++);
var id = single.Identifier;
var declSymbol = cx.Model(single).GetDeclaredSymbol(single);
var location = cx.Create(id.GetLocation());
LocalVariable.Create(cx, local, decl, true, location);
}

4
csharp/extractor/Semmle.Extraction.CSharp/Entities/Statements/Case.cs
View File

@@ -75,7 +75,7 @@ namespace Semmle.Extraction.CSharp.Entities.Statements
switch (designation)
{
case SingleVariableDesignationSyntax single:
case SingleVariableDesignationSyntax _:
if (cx.Model(pattern).GetDeclaredSymbol(designation) is ILocalSymbol symbol)
{
var type = Type.Create(cx, symbol.Type);
@@ -92,7 +92,7 @@ namespace Semmle.Extraction.CSharp.Entities.Statements
case null:
break;
case ParenthesizedVariableDesignationSyntax paren:
Expressions.VariableDeclaration.CreateParenthesized(cx, pattern as VarPatternSyntax, paren, this, 0);
Expressions.VariableDeclaration.CreateParenthesized(cx, (VarPatternSyntax)pattern, paren, this, 0);
break;
default:
throw new InternalError(pattern, "Unhandled designation in case statement");