hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Normalize parentheses.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2018-11-28 15:01:25 +01:00
parent 41edd61e2e
commit ae44b90456
84 changed files with 649 additions and 876 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/src/Performance/ConcatenationInLoops.ql
View File

@@ -38,10 +38,8 @@ predicate useAndDef(Assignment a, Variable v) {
(
a instanceof AssignAddExpr
or
(
exists(VarAccess use | use.getVariable() = v | use.getParent*() = a.getSource()) and
a.getSource() instanceof AddExpr
)
exists(VarAccess use | use.getVariable() = v | use.getParent*() = a.getSource()) and
a.getSource() instanceof AddExpr
)
}

8
java/ql/src/Performance/InnerClassCouldBeStatic.ql
View File

@@ -20,7 +20,7 @@ import java
predicate inherits(Class c, Field f) {
f = c.getAField()
or
(not f.isPrivate() and c.getASupertype+().getAField() = f)
not f.isPrivate() and c.getASupertype+().getAField() = f
}
/**
@@ -37,10 +37,10 @@ RefType enclosingInstanceAccess(Expr expr) {
exists(RefType enclosing | enclosing = expr.getEnclosingCallable().getDeclaringType() |
// A direct qualified `this` access that doesn't refer to the containing
// class must refer to an enclosing instance instead.
(result = expr.(ThisAccess).getType() and result != enclosing)
result = expr.(ThisAccess).getType() and result != enclosing
or
// A qualified `super` access qualified with a type that isn't the enclosing type.
(result = expr.(SuperAccess).getQualifier().(TypeAccess).getType() and result != enclosing)
result = expr.(SuperAccess).getQualifier().(TypeAccess).getType() and result != enclosing
or
// An unqualified `new` expression constructing a
// non-static type that needs an enclosing instance.
@@ -94,7 +94,7 @@ predicate potentiallyStatic(InnerClass c) {
InnerClass other // If nested and non-static, ...
|
// ... all supertypes (which are from source), ...
(other = c.getASourceSupertype() and other.fromSource())
other = c.getASourceSupertype() and other.fromSource()
or
// ... and the enclosing type, ...
other = c.getEnclosingType()