hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-01 05:13:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Misc grammar and formatting.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2020-07-06 16:15:16 +02:00
parent b06d1c715a
commit ae21de90b6
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
java/ql/src/semmle/code/java/frameworks/spring/SpringController.qll
View File

@@ -19,7 +19,7 @@ class SpringControllerAnnotation extends AnnotationType {
/**
* An annotation type that identifies Spring rest controllers.
*
* Rest controllers are the same as controllers, but imply the @ResponseBody annotation.
* Rest controllers are the same as controllers, but imply the `@ResponseBody` annotation.
*/
class SpringRestControllerAnnotation extends SpringControllerAnnotation {
SpringRestControllerAnnotation() { hasName("RestController") }
@@ -78,7 +78,7 @@ class SpringInitBinderMethod extends SpringControllerMethod {
}
/**
* An `AnnotationType` which is used to indicate a `RequestMapping`.
* An `AnnotationType` that is used to indicate a `RequestMapping`.
*/
class SpringRequestMappingAnnotationType extends AnnotationType {
SpringRequestMappingAnnotationType() {
@@ -91,7 +91,7 @@ class SpringRequestMappingAnnotationType extends AnnotationType {
}
/**
* An `AnnotationType` which is used to indicate a `ResponseBody`.
* An `AnnotationType` that is used to indicate a `ResponseBody`.
*/
class SpringResponseBodyAnnotationType extends AnnotationType {
SpringResponseBodyAnnotationType() {
@@ -126,12 +126,10 @@ class SpringRequestMappingMethod extends SpringControllerMethod {
requestMappingAnnotation.getValue("produces").(CompileTimeConstantExpr).getStringValue()
}
/** Holds if this is considered an @ResponseBody method. */
/** Holds if this is considered an `@ResponseBody` method. */
predicate isResponseBody() {
getAnAnnotation().getType() instanceof SpringResponseBodyAnnotationType
or
getDeclaringType().getAnAnnotation().getType() instanceof SpringResponseBodyAnnotationType
or
getAnAnnotation().getType() instanceof SpringResponseBodyAnnotationType or
getDeclaringType().getAnAnnotation().getType() instanceof SpringResponseBodyAnnotationType or
getDeclaringType() instanceof SpringRestController
}
}
@@ -242,13 +240,13 @@ class SpringRequestMappingParameter extends Parameter {
not isImplicitRequestParam()
}
/** Holds if this is an explicit or implicit @ModelAttribute parameter */
/** Holds if this is an explicit or implicit `@ModelAttribute` parameter. */
predicate isModelAttribute() {
isImplicitModelAttribute() or
getAnAnnotation() instanceof SpringModelAttributeAnnotation
}
/** Holds if the input is tainted */
/** Holds if the input is tainted. */
predicate isTaintedInput() {
isExplicitlyTaintedInput()
or
@@ -329,7 +327,7 @@ private RefType stripType(Type t) {
/**
* A user data type that may be populated from an HTTP request.
*
* This includes types directly referred to as either @ModelAttribute or @RequestBody parameters,
* This includes types directly referred to as either `@ModelAttribute` or `@RequestBody` parameters,
* or types that are referred to by those types.
*/
class SpringUntrustedDataType extends RefType {