hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Exclude .kt files from java/complex-boolean-expression

Browse Source
This commit is contained in:
Tamas Vajk
2022-11-16 09:38:39 +01:00
parent de833d620e
commit ac85d2eb3e
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/ql/src/Violations of Best Practice/Boolean Logic/SimplifyBoolExpr.ql
View File

@@ -92,13 +92,16 @@ class ComparisonOrEquality extends BinaryExpr {
from Expr e, string pattern, string rewrite
where
e.(BoolCompare).simplify(pattern, rewrite)
or
conditionalWithBool(e, pattern, rewrite)
or
e.(LogNotExpr).getExpr().(ComparisonOrEquality).negate(pattern, rewrite)
or
e.(LogNotExpr).getExpr() instanceof LogNotExpr and
pattern = "!!A" and
rewrite = "A"
e.getFile().isJavaSourceFile() and
(
e.(BoolCompare).simplify(pattern, rewrite)
or
conditionalWithBool(e, pattern, rewrite)
or
e.(LogNotExpr).getExpr().(ComparisonOrEquality).negate(pattern, rewrite)
or
e.(LogNotExpr).getExpr() instanceof LogNotExpr and
pattern = "!!A" and
rewrite = "A"
)
select e, "Expressions of the form \"" + pattern + "\" can be simplified to \"" + rewrite + "\"."

1
java/ql/test/kotlin/query-tests/SimplifyBoolExpr/SimplifyBoolExpr.expected
View File

@@ -1 +0,0 @@
| SimplifyBoolExpr.kt:8:8:8:16 | ... (value equals) ... | Expressions of the form "A == true" can be simplified to "A". |