From ac4601cb8fca067c8e5a77a968c65f7dba702ed6 Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 8 Mar 2024 13:01:38 +0100 Subject: [PATCH] Update javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll Co-authored-by: Rasmus Wriedt Larsen --- .../ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll index 682c9a2dffa..7e55944038b 100644 --- a/javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll +++ b/javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll @@ -250,7 +250,7 @@ module CallGraph { result = node.(DataFlow::ObjectLiteralNode).getPropertySetter(_) ) and not node.getTopLevel().isExterns() and - // Do not track instance methods on classes + // Ignore writes to `this` inside a constructor, since this is already handled by instance method tracking not exists(DataFlow::ClassNode cls | node = cls.getConstructor().getReceiver() or