diff --git a/javascript/ql/src/semmle/javascript/Expr.qll b/javascript/ql/src/semmle/javascript/Expr.qll index ff159f23f00..1b2ff1f61bf 100644 --- a/javascript/ql/src/semmle/javascript/Expr.qll +++ b/javascript/ql/src/semmle/javascript/Expr.qll @@ -250,7 +250,7 @@ class Expr extends @expr, ExprOrStmt, ExprOrType, AST::ValueNode { * Gets the data-flow node where exceptional data-flow will flow if this expression * causes an exception to be thrown. */ - DataFlow::Node getThrowsToNode() { + DataFlow::Node getExceptionalNode() { if exists(this.getEnclosingStmt().getEnclosingTryCatchStmt()) then result = DataFlow::parameterNode(this diff --git a/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll b/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll index ed441ce5b89..bde0297e5c6 100644 --- a/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll +++ b/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll @@ -66,7 +66,7 @@ predicate localExceptionStep(DataFlow::Node pred, DataFlow::Node succ) { or DataFlow::exceptionalInvocationReturnNode(pred, expr) | - succ = expr.getThrowsToNode() + succ = expr.getExceptionalNode() ) } diff --git a/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll b/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll index e419ec46b12..c3b91360004 100644 --- a/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll +++ b/javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll @@ -73,7 +73,7 @@ module ExceptionXss { DataFlow::FlowLabel outlbl ) { inlbl instanceof NotYetThrown and (outlbl.isTaint() or outlbl instanceof NotYetThrown) and - succ = pred.asExpr().getThrowsToNode() and + succ = pred.asExpr().getExceptionalNode() and canThrowSensitiveInformation(pred) or // All the usual taint-flow steps apply on data-flow before it has been thrown in an exception.