From ab797065abc78e48bc2b4dfad1ea50fe3ce449d0 Mon Sep 17 00:00:00 2001
From: Kasper Svendsen <kaspersv@github.com>
Date: Tue, 27 Jun 2023 11:49:37 +0200
Subject: [PATCH] Go: Enable implicit this warnings for remaining packs

---
 go/downgrades/qlpack.yml                                | 1 +
 go/external-packs/codeql/suite-helpers/0.0.2/qlpack.yml | 1 +
 go/ql/config/legacy-support/qlpack.yml                  | 1 +
 go/ql/examples/qlpack.yml                               | 1 +
 go/ql/integration-tests/all-platforms/go/qlpack.yml     | 1 +
 go/ql/integration-tests/linux-only/go/qlpack.yml        | 1 +
 6 files changed, 6 insertions(+)

diff --git a/go/downgrades/qlpack.yml b/go/downgrades/qlpack.yml
index d3e056bea64..7e8e0022eb0 100644
--- a/go/downgrades/qlpack.yml
+++ b/go/downgrades/qlpack.yml
@@ -2,3 +2,4 @@ name: codeql/go-downgrades
 groups: go
 downgrades: .
 library: true
+warnOnImplicitThis: true
diff --git a/go/external-packs/codeql/suite-helpers/0.0.2/qlpack.yml b/go/external-packs/codeql/suite-helpers/0.0.2/qlpack.yml
index ca0a6732f5a..7c42cb6974c 100644
--- a/go/external-packs/codeql/suite-helpers/0.0.2/qlpack.yml
+++ b/go/external-packs/codeql/suite-helpers/0.0.2/qlpack.yml
@@ -1,3 +1,4 @@
 name: codeql/suite-helpers
 version: 0.0.2
 library: true
+warnOnImplicitThis: true
diff --git a/go/ql/config/legacy-support/qlpack.yml b/go/ql/config/legacy-support/qlpack.yml
index bf3ee4d72a6..23ba44acd80 100644
--- a/go/ql/config/legacy-support/qlpack.yml
+++ b/go/ql/config/legacy-support/qlpack.yml
@@ -2,3 +2,4 @@ name: legacy-libraries-go
 version: 0.0.0
 # Note libraryPathDependencies is obsolete and should not be used in new qlpacks.
 libraryPathDependencies: codeql-go
+warnOnImplicitThis: true
diff --git a/go/ql/examples/qlpack.yml b/go/ql/examples/qlpack.yml
index 1f2ca2cd40a..006eb3c17b3 100644
--- a/go/ql/examples/qlpack.yml
+++ b/go/ql/examples/qlpack.yml
@@ -4,3 +4,4 @@ groups:
   - examples
 dependencies:
   codeql/go-all: ${workspace}
+warnOnImplicitThis: true
diff --git a/go/ql/integration-tests/all-platforms/go/qlpack.yml b/go/ql/integration-tests/all-platforms/go/qlpack.yml
index 3a018bff52a..2fc2dd566dd 100644
--- a/go/ql/integration-tests/all-platforms/go/qlpack.yml
+++ b/go/ql/integration-tests/all-platforms/go/qlpack.yml
@@ -2,3 +2,4 @@ dependencies:
   codeql/go-all: '*'
   codeql/go-tests: '*'
   codeql/go-queries: '*'
+warnOnImplicitThis: true
diff --git a/go/ql/integration-tests/linux-only/go/qlpack.yml b/go/ql/integration-tests/linux-only/go/qlpack.yml
index 3a018bff52a..2fc2dd566dd 100644
--- a/go/ql/integration-tests/linux-only/go/qlpack.yml
+++ b/go/ql/integration-tests/linux-only/go/qlpack.yml
@@ -2,3 +2,4 @@ dependencies:
   codeql/go-all: '*'
   codeql/go-tests: '*'
   codeql/go-queries: '*'
+warnOnImplicitThis: true