hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor StringPercentCall#getFormatArgument

Browse Source
This commit is contained in:
erik-krogh
2022-10-24 18:57:24 +02:00
parent c13e8e4f48
commit aafef382dc
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ruby/ql/lib/codeql/ruby/frameworks/StringFormatters.qll
View File

@@ -87,13 +87,15 @@ class StringPercentCall extends PrintfStyleCall {
override DataFlow::Node getFormatString() { result = this.getReceiver() }
override DataFlow::Node getFormatArgument(int n) {
exists(DataFlow::CallNode arrCall |
arrCall = this.getArgument(0) and arrCall.getMethodName() = "[]"
|
n = -2 and // -2 is indicates that the index does not make sense in this context
result = arrCall.getKeywordArgument(_)
exists(Ast::Call call | call = this.asExpr().getExpr() |
exists(Ast::ArrayLiteral arrLit | arrLit = call.getArgument(0) |
result.asExpr().getExpr() = arrLit.getElement(n)
)
or
result = arrCall.getArgument(n)
exists(Ast::HashLiteral hashLit | hashLit = call.getArgument(0) |
n = -2 and // -2 is indicates that the index does not make sense in this context
result.asExpr().getExpr() = hashLit.getAnElement()
)
)
}