hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-12 10:19:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: exclude global vars from local flow

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2020-07-03 08:41:10 +02:00
parent bdc68ce6b6
commit a9e0288e5b
5 changed files with 2 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll
View File

@@ -90,6 +90,8 @@ module EssaFlow {
* excludes SSA flow through instance fields.
*/
predicate simpleLocalFlowStep(Node nodeFrom, Node nodeTo) {
not nodeFrom.(EssaNode).getVar() instanceof GlobalSsaVariable and
not nodeTo.(EssaNode).getVar() instanceof GlobalSsaVariable and
EssaFlow::essaFlowStep(nodeFrom, nodeTo)
}

1
python/ql/src/experimental/dataflow/internal/readme.md
View File

@@ -135,4 +135,3 @@ Try recovering an existing taint tracking query by implementing sources, sinks,
- What should the enclosable callable for global variables be? C++ makes it the variable itself, C# seems to not have nodes for these but only for their reads and writes.
- Is `yield` another return type? If not, how is it handled?
- Should `OutNode` include magic function calls?
- Remove local flow to/from global variables