hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix up test

Browse Source
This commit is contained in:
Joe Farebrother
2021-10-21 16:46:07 +01:00
parent 3e3503a763
commit a9dde419d2
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll
View File

@@ -150,8 +150,8 @@ private predicate isCleanIntent(Expr intent) {
/**
* Taint configuration tracking flow from variables containing sensitive information to broadcast intents.
*/
class SensitiveBroadcastConfig extends TaintTracking::Configuration {
SensitiveBroadcastConfig() { this = "Sensitive Broadcast Configuration" }
class SensitiveCommunicationConfig extends TaintTracking::Configuration {
SensitiveCommunicationConfig() { this = "Sensitive Communication Configuration" }
override predicate isSource(DataFlow::Node source) {
source.asExpr() instanceof SensitiveInfoExpr

6
java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.ql
View File

@@ -14,7 +14,7 @@ import java
import semmle.code.java.security.AndroidSensitiveCommunicationQuery
import DataFlow::PathGraph
from SensitiveBroadcastConfig cfg, DataFlow::PathNode source, DataFlow::PathNode sink
from SensitiveCommunicationConfig cfg, DataFlow::PathNode source, DataFlow::PathNode sink
where cfg.hasFlowPath(source, sink)
select sink.getNode(), source, sink, "Sending $@ to broadcast.", source.getNode(),
"sensitive information"
select sink.getNode(), source, sink, "This call may leak sensitive infomration from $@.",
source.getNode(), "here"

6
java/ql/test/query-tests/security/CWE-927/SensitiveCommunication.ql
View File

@@ -1,10 +1,12 @@
import java
import semmle.code.java.security.AndroidSensitiveBroadcastQuery
import semmle.code.java.security.AndroidSensitiveCommunicationQuery
import TestUtilities.InlineExpectationsTest
import TestUtilities.InlineFlowTest
class HasFlowTest extends InlineFlowTest {
override DataFlow::Configuration getTaintFlowConfig() { result = any(SensitiveBroadcastConfig c) }
override DataFlow::Configuration getTaintFlowConfig() {
result = any(SensitiveCommunicationConfig c)
}
override DataFlow::Configuration getValueFlowConfig() { none() }
}