hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update zipslip_bad.py

Browse Source
This commit is contained in:
Ahmed Farid
2022-03-28 01:00:38 +00:00
committed by GitHub
parent ddba3b7784
commit a8c14ed6c3
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
python/ql/test/experimental/query-tests/Security/CWE-022/zipslip_bad.py
View File

@@ -9,29 +9,30 @@ def unzip(filename):
#BAD : This could write any file on the filesystem.
for entry in zipf:
shutil.move(entry, "/tmp/unpack/")
def unzip1(filename):
with gzip.open(filename) as zipf:
#BAD : This could write any file on the filesystem.
for entry in zipf:
shutil.copy2(entry, "/tmp/unpack/")
def unzip2(filename):
with bz2.open(filename) as zipf:
#BAD : This could write any file on the filesystem.
for entry in zipf:
shutil.copyfile(entry, "/tmp/unpack/")
def unzip3(filename):
with zipfile.ZipFile(filename) as zipf:
zf = zipfile.ZipFile(filename)
filelist = zf.namelist()
#BAD : This could write any file on the filesystem.
for entry in zipf:
for filename in filelist:
shutil.copy(entry, "/tmp/unpack/")
def unzip4(filename):
with zipfile.ZipFile(filename) as zipf:
for entry in zipf:
with open(entry, 'wb') as dstfile:
shutil.copyfileobj(zipf, dstfile)
zf = zipfile.ZipFile(filename)
filelist = zf.namelist()
for filename in filelist:
with zf.open(filename) as srcf:
shutil.copyfileobj(srcf, dstfile)