hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Improve performance of definitions.qll.

Browse Source
This commit is contained in:
Cornelius Riemenschneider
2020-10-23 15:16:53 +02:00
parent 9388448053
commit a82cf74161
5 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/test/query-tests/definitions/locationInfo.ql
View File

@@ -4,7 +4,7 @@ import definitions
* An element that is the source of a jump-to-definition link.
*/
class Link extends Top {
Link() { exists(definitionOf(this, _, false)) }
Link() { exists(definitionOf(this, _)) }
}
/**
@@ -31,7 +31,7 @@ predicate linkLocationInfo(Link e, string filepath, int begin, int end) {
* Gets a string describing a problem with a `Link`.
*/
string issues(Link e) {
strictcount(Top def | def = definitionOf(e, _, false)) > 1 and
strictcount(Top def | def = definitionOf(e, _)) > 1 and
result = "has more than one definition"
or
exists(string filepath1, int begin1, int end1, Link e2, string filepath2, int begin2, int end2 |
@@ -40,7 +40,9 @@ string issues(Link e) {
filepath1 = filepath2 and
not end1 < begin2 and
not begin1 > end2 and
e != e2
e != e2 and
not e.isFromTemplateInstantiation(_) and
not e2.isFromTemplateInstantiation(_)
) and
result = "overlaps another link"
}