hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1176 from xiemaisi/js/fix-socket-io-type-tracking

Browse Source 
Approved by asger-semmle
This commit is contained in:
semmle-qlci
2019-04-01 13:57:13 +01:00
committed by GitHub
parent 76caad0fb4 62c895de3e
commit a7d9a50dcf
4 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
javascript/ql/test/library-tests/frameworks/SocketIO/tests.expected
View File

@@ -149,6 +149,7 @@ test_ServerNode
| tst.js:15:1:15:15 | io.attach(http) | tst.js:1:12:1:33 | socket.io server |
| tst.js:16:1:16:15 | io.bind(engine) | tst.js:1:12:1:33 | socket.io server |
| tst.js:17:1:17:23 | io.onco ... socket) | tst.js:1:12:1:33 | socket.io server |
| tst.js:79:1:79:10 | obj.server | tst.js:1:12:1:33 | socket.io server |
test_ClientSendNode_getAReceiver
| client2.js:14:1:14:32 | sock.em ... there") | tst.js:72:3:72:43 | socket. ... => {}) |
| client2.js:16:1:16:36 | sock.wr ... => {}) | tst.js:70:3:70:35 | socket. ... => {}) |

8
javascript/ql/test/library-tests/frameworks/SocketIO/tst.js
View File

@@ -71,3 +71,11 @@ ns.on('connection', (socket) => {
socket.once('message', (data1, data2) => {});
socket.addListener(eventName(), () => {});
});
var obj = {
server: io,
serveClient: function() { return null; }
};
obj.server; // SocketIO::ServerNode
obj.serveClient(false); // not a SocketIO::ServerNode
obj.serveClient(false).server; // not a SocketIO::ServerNode