mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
Address review comments in annotations.py
This commit is contained in:
@@ -231,16 +231,15 @@ class _:
|
|||||||
@annotate(CallExpr, cfg=True)
|
@annotate(CallExpr, cfg=True)
|
||||||
class _:
|
class _:
|
||||||
"""
|
"""
|
||||||
NOTE: Consider using `Call` instead, as that includes all kinds of calls to
|
NOTE: Consider using `Call` instead, as that excludes call expressions that are
|
||||||
functions, and excludes instantiations of tuple structs and tuple enum variants.
|
instantiations of tuple structs and tuple variants.
|
||||||
|
|
||||||
A call expression. For example:
|
A call expression. For example:
|
||||||
```rust
|
```rust
|
||||||
foo(42);
|
foo(42);
|
||||||
foo::<u32, u64>(42);
|
foo::<u32, u64>(42);
|
||||||
foo[0](42);
|
foo[0](42);
|
||||||
foo(1) = 4;
|
Option::Some(42); // tuple variant instantiation
|
||||||
Option::Some(42); // tuple enum variant instantiation
|
|
||||||
```
|
```
|
||||||
"""
|
"""
|
||||||
|
|
||||||
@@ -249,8 +248,8 @@ class _:
|
|||||||
class _:
|
class _:
|
||||||
"""
|
"""
|
||||||
NOTE: Consider using `MethodCall` instead, as that also includes calls to methods using
|
NOTE: Consider using `MethodCall` instead, as that also includes calls to methods using
|
||||||
function call syntax (such as `Foo::method(x)`), operator calls (such as `x + y`), and
|
call syntax (such as `Foo::method(x)`), operation syntax (such as `x + y`), and
|
||||||
indexing calls (such as `x[y]`).
|
indexing syntax (such as `x[y]`).
|
||||||
|
|
||||||
A method call expression. For example:
|
A method call expression. For example:
|
||||||
```rust
|
```rust
|
||||||
@@ -1921,7 +1920,7 @@ class _:
|
|||||||
@annotate(TupleField)
|
@annotate(TupleField)
|
||||||
class _:
|
class _:
|
||||||
"""
|
"""
|
||||||
A field in a tuple struct or tuple enum variant.
|
A field in a tuple struct or tuple variant.
|
||||||
|
|
||||||
For example:
|
For example:
|
||||||
```rust
|
```rust
|
||||||
@@ -1934,7 +1933,7 @@ class _:
|
|||||||
@annotate(TupleFieldList)
|
@annotate(TupleFieldList)
|
||||||
class _:
|
class _:
|
||||||
"""
|
"""
|
||||||
A list of fields in a tuple struct or tuple enum variant.
|
A list of fields in a tuple struct or tuple variant.
|
||||||
|
|
||||||
For example:
|
For example:
|
||||||
```rust
|
```rust
|
||||||
|
|||||||
Reference in New Issue
Block a user