hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Minor refactoring to avoid introducing name variable.

Browse Source
This commit is contained in:
Michael Nebel
2022-07-25 09:48:21 +02:00
parent 72429cb9e8
commit a7011e11c4
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll
View File

@@ -196,12 +196,8 @@ class MicrosoftAspNetCoreMvcControllerBaseClass extends Class {
*/
class MicrosoftAspNetCoreMvcController extends Class {
MicrosoftAspNetCoreMvcController() {
exists(Assembly a, string name |
a.getName() = name and
(
name = "Microsoft.AspNetCore.Mvc.Core" or
name = "Microsoft.AspNetCore.Mvc.ViewFeatures"
)
exists(Assembly a |
a.getName() = ["Microsoft.AspNetCore.Mvc.Core", "Microsoft.AspNetCore.Mvc.ViewFeatures"]
) and
this.isPublic() and
not this.isAbstract() and

4
csharp/ql/test/library-tests/frameworks/microsoft/AspNetCore.cs
View File

@@ -10,7 +10,7 @@ public class HomeController
}
// derived from Microsoft.AspNetCore.Mvc.Controller which has suffix "Controller"
public class HomeController1 : Controller
public class HomeController1 : Controller
{
public string Index()
{
@@ -74,7 +74,7 @@ public abstract class NotHomeController2 : Controller
}
}
// contains generic paramiters
// contains generic parameters
public class NotHomeController3<T> : Controller
{
public string Index()