hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-12 05:01:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix asDefinition to not only work for SSA definitions.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2026-01-23 16:23:21 +00:00
parent e58a8330cd
commit a556152b9d
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
View File

@@ -312,6 +312,13 @@ class Node extends TIRDataFlowNode {
*/
Expr asDefinition() { result = this.asDefinition(_) }
private predicate isCertainStore() {
exists(SsaImpl::Definition def |
SsaImpl::defToNode(this, def, _) and
def.isCertain()
)
}
/**
* Gets the definition associated with this node, if any.
*
@@ -361,11 +368,10 @@ class Node extends TIRDataFlowNode {
* pointed to by `p`.
*/
Expr asDefinition(boolean uncertain) {
exists(StoreInstruction store, SsaImpl::Definition def |
exists(StoreInstruction store |
store = this.asInstruction() and
result = asDefinitionImpl(store) and
SsaImpl::defToNode(this, def, _) and
if def.isCertain() then uncertain = false else uncertain = true
if this.isCertainStore() then uncertain = false else uncertain = true
)
}

6
cpp/ql/test/library-tests/dataflow/asDefinition/test.cpp
View File

@@ -10,9 +10,9 @@ void test() {
y = 44; // $ asDefinition="... = ..."
use(y);
int x = 43; // $ MISSING: asDefinition=43
x = 44; // $ MISSING: asDefinition="... = ..."
int x = 43; // $ asDefinition=43
x = 44; // $ asDefinition="... = ..."
S s;
s.x = 42; // $ MISSING: asDefinition="... = ..."
s.x = 42; // $ asDefinition="... = ..."
}