Restrict field access to corresponding type

2025-12-20 18:56:32 +01:00 · 2021-11-09 11:42:49 +01:00
parent 6960a7b97e
commit a546b38ee0
1 changed files with 2 additions and 2 deletions
--- a/java/ql/src/utils/model-generator/CaptureSummaryModels.ql
+++ b/java/ql/src/utils/model-generator/CaptureSummaryModels.ql
@@ -96,8 +96,8 @@ class ParameterToFieldConfig extends TaintTracking::Configuration {
  override predicate isSink(DataFlow::Node sink) {
    exists(FieldAssignment a |
      a.getSource() = sink.asExpr() and
-      a.getDest().(VarAccess).getVariable().getCompilationUnit() =
-        sink.getEnclosingCallable().getCompilationUnit()
+      a.getDest().(FieldAccess).getField().getDeclaringType() =
+        sink.getEnclosingCallable().getDeclaringType()
    )
  }
 }