hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 04:06:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

highlight the use of the regular expression, instead of the sink for user input

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2021-01-14 11:22:20 +01:00
parent e8ea720650
commit a520a51d42
3 changed files with 90 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/src/Performance/PolynomialReDoS.ql
View File

@@ -16,13 +16,13 @@ import semmle.javascript.security.performance.PolynomialReDoS::PolynomialReDoS
import semmle.javascript.security.performance.SuperlinearBackTracking
import DataFlow::PathGraph
from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink, Sink sinkNode
where
cfg.hasFlowPath(source, sink) and
sinkNode = sink.getNode() and
not (
source.getNode().(Source).getKind() = "url" and
sink.getNode().(Sink).getRegExp().(PolynomialBackTrackingTerm).isAtEndLine()
sinkNode.getRegExp().(PolynomialBackTrackingTerm).isAtEndLine()
)
select sink.getNode(), source, sink, "This expensive $@ use depends on $@.",
sink.getNode().(Sink).getRegExp(), "regular expression", source.getNode(),
source.getNode().(Source).describe()
select sinkNode.getHighlight(), source, sink, "This expensive $@ use depends on $@.",
sinkNode.getRegExp(), "regular expression", source.getNode(), source.getNode().(Source).describe()