hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

apply suggestion from review

Browse Source
This commit is contained in:
erik-krogh
2022-08-23 15:41:37 +02:00
parent 1a7d3ee831
commit a50234adb0
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/Expressions/BitwiseSignCheck.ql
View File

@@ -53,4 +53,4 @@ where
not e instanceof EqualityTest and
e.getRightOperand().getIntValue() = 0 and
not acceptableSignCheck(b)
select e, "Potential unsafe sign check of a bitwise operation."
select e, "Potentially unsafe sign check of a bitwise operation."

6
javascript/ql/test/query-tests/Expressions/BitwiseSignCheck/BitwiseSignCheck.expected
View File

@@ -1,3 +1,3 @@
| tst.js:2:9:2:24 | (x & (1<<n)) > 0 | Potential unsafe sign check of a bitwise operation. |
| tst.js:14:13:14:25 | (x >>> 0) > 0 | Potential unsafe sign check of a bitwise operation. |
| tst.js:23:1:23:21 | (x & 0x ... 00) > 0 | Potential unsafe sign check of a bitwise operation. |
| tst.js:2:9:2:24 | (x & (1<<n)) > 0 | Potentially unsafe sign check of a bitwise operation. |
| tst.js:14:13:14:25 | (x >>> 0) > 0 | Potentially unsafe sign check of a bitwise operation. |
| tst.js:23:1:23:21 | (x & 0x ... 00) > 0 | Potentially unsafe sign check of a bitwise operation. |