hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Guards: Slight join-order improvement.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-07-24 15:26:38 +02:00
parent ec513ead0d
commit a40ae3a11a
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shared/controlflow/codeql/controlflow/Guards.qll
View File

@@ -1031,6 +1031,11 @@ module Make<LocationSig Location, InputSig<Location> Input> {
module ReturnImplies = ImpliesTC<returnGuard/2>; module ReturnImplies = ImpliesTC<returnGuard/2>;
pragma[nomagic]
private predicate directlyControlsReturn(Guard guard, GuardValue val, ReturnExpr ret) {
guard.directlyValueControls(ret.getBasicBlock(), val)
}
/** /**
* Holds if `ret` is a return expression in a non-overridable method that * Holds if `ret` is a return expression in a non-overridable method that
* on a return value of `retval` allows the conclusion that the `ppos`th * on a return value of `retval` allows the conclusion that the `ppos`th
@@ -1044,7 +1049,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
parameterDefinition(m.getParameter(ppos), param) parameterDefinition(m.getParameter(ppos), param)
| |
exists(Guard g0, GuardValue v0 | exists(Guard g0, GuardValue v0 |
g0.directlyValueControls(ret.getBasicBlock(), v0) and directlyControlsReturn(g0, v0, ret) and
BranchImplies::ssaControls(param, val, g0, v0) and BranchImplies::ssaControls(param, val, g0, v0) and
relevantReturnValue(m, retval) relevantReturnValue(m, retval)
) )