hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 04:06:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Asger F <asgerf@github.com>
This commit is contained in:
Erik Krogh Kristensen
2020-11-19 11:42:12 +01:00
committed by GitHub
parent cc1d797cef
commit a3b21ad43b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/Performance/ReDoS.ql
View File

@@ -871,11 +871,11 @@ predicate isPumpable(State fork, string w) {
* This assumption breaks on regular expression that use the anchor `$`, e.g: `/^(a+)+$/`, and such regular * This assumption breaks on regular expression that use the anchor `$`, e.g: `/^(a+)+$/`, and such regular
* expression are not accurately modeled by this query. * expression are not accurately modeled by this query.
* *
* The the string `w` is repeated any number of times because the string `w` needs to be * The string `w` is repeated any number of times because it needs to be
* infinitely repeatedable for the attack to work. * infinitely repeatedable for the attack to work.
* For a regular expression `/((ab)+)*abab/` the accepting state is not reachable from the fork * For a regular expression `/((ab)+)*abab/` the accepting state is not reachable from the fork
* using epsilon transitions. But any attempt at repeating `w` will end in the accepting state. * using epsilon transitions. But any attempt at repeating `w` will end in the accepting state.
* This is also build on the assumption that any accepting state will accept all suffixes. * This also relies on the assumption that any accepting state will accept all suffixes.
*/ */
State process(State fork, string w, int i) { State process(State fork, string w, int i) {
isPumpable(fork, w) and isPumpable(fork, w) and