hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#/Java: Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2024-06-14 10:46:19 +02:00
parent 7f7c5d7c94
commit a29446a566
4 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/src/utils/modelgenerator/internal/CaptureModels.qll
View File

@@ -41,15 +41,6 @@ private module Printing implements PrintingSig {
module ModelPrinting = PrintingImpl<Printing>;
/**
* Gets the underlying type of the content `c`.
*/
private Type getUnderlyingContentType(DataFlow::Content c) {
result = getUnderlyingContentTypeSpecific(c) or
result = c.(DataFlow::FieldContent).getField().getType() or
result = c.(DataFlow::SyntheticFieldContent).getField().getType()
}
/**
* Holds if `c` is a relevant content kind, where the underlying type is relevant.
*/

8
java/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
View File

@@ -186,7 +186,13 @@ predicate isRelevantType(J::Type t) {
)
}
J::Type getUnderlyingContentTypeSpecific(DataFlow::Content c) { none() }
/**
* Gets the underlying type of the content `c`.
*/
J::Type getUnderlyingContentType(DataFlow::Content c) {
result = c.(DataFlow::FieldContent).getField().getType() or
result = c.(DataFlow::SyntheticFieldContent).getField().getType()
}
/**
* Gets the MaD string representation of the qualifier.