hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-25 00:27:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

In the MaD data, set the subtypes field to false for final classes / methods.

Browse Source
This commit is contained in:
tiferet
2023-02-08 10:45:40 -08:00
parent 4b6d1f7b78
commit a27ae27101
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll
View File

@@ -102,9 +102,13 @@ predicate hasMetadata(DataFlow::Node n, string metadata) {
callee = call.getCallee() and
package = callee.getDeclaringType().getPackage().getName() and
type = callee.getDeclaringType().getName() and //TODO: Will this work for inner classes? Will it produce X$Y? What about lambdas? What about enums? What about interfaces? What about annotations?
subtypes = true and // see https://github.slack.com/archives/CP9127VUK/p1673979477496069
(
if callee.isFinal() or callee.getDeclaringType().isFinal()
then subtypes = false // See https://github.com/github/codeql-java-team/issues/254#issuecomment-1422296423
else subtypes = true
) and
name = callee.getName() and // TODO: Will this work for constructors?
signature = paramsString(callee) and
signature = paramsString(callee) and // TODO: Why are brackets being escaped (`\[\]` vs `[]`)?
ext = "" and // see https://github.slack.com/archives/CP9127VUK/p1673979477496069
provenance = "manual" and // TODO
(if callee.isPublic() then isPublic = true else isPublic = false) and