hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6865 from MathiasVP/fix-if-none

Browse Source 
C++/C#/JS/Python: Replace 'if p() then q() else none()' with a conjunction
This commit is contained in:
Mathias Vorreiter Pedersen
2021-10-13 19:47:55 +01:00
committed by GitHub
parent 2b0415e238 bdc54bcda7
commit a2371370ff
10 changed files with 36 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/ql/src/Functions/SignatureSpecialMethods.ql
View File

@@ -132,12 +132,12 @@ predicate incorrect_special_method_defn(
else
if required < func.minParameters()
then message = "Too many parameters" and show_counts = true
else
if func.minParameters() < required and not func.getScope().hasVarArg()
then
message = (required - func.minParameters()) + " default values(s) will never be used" and
show_counts = false
else none()
else (
func.minParameters() < required and
not func.getScope().hasVarArg() and
message = (required - func.minParameters()) + " default values(s) will never be used" and
show_counts = false
)
)
}