From a235f8f023d15439124e1d5ee51359bf810d088a Mon Sep 17 00:00:00 2001
From: Erik Krogh Kristensen <erik-krogh@github.com>
Date: Thu, 20 Jan 2022 21:38:44 +0100
Subject: [PATCH] remove redundant inline type casts

---
 .../Security/CWE/CWE-377/InsecureTemporaryFile.ql             | 2 +-
 java/ql/src/utils/model-generator/CaptureSummaryModels.ql     | 2 +-
 .../javascript/dataflow/internal/InterModuleTypeInference.qll | 4 ++--
 python/ql/lib/semmle/python/frameworks/FastApi.qll            | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-377/InsecureTemporaryFile.ql b/cpp/ql/src/experimental/Security/CWE/CWE-377/InsecureTemporaryFile.ql
index f08f7ef61f5..877b67cbbf8 100644
--- a/cpp/ql/src/experimental/Security/CWE/CWE-377/InsecureTemporaryFile.ql
+++ b/cpp/ql/src/experimental/Security/CWE/CWE-377/InsecureTemporaryFile.ql
@@ -92,7 +92,7 @@ where
     ) and
     exists(Variable vrtmp |
       vrtmp = fc.getArgument(0).(VariableAccess).getTarget() and
-      vrtmp = fctmp.getArgument(0).(AddressOfExpr).getAddressable().(Variable) and
+      vrtmp = fctmp.getArgument(0).(AddressOfExpr).getAddressable() and
       not vrtmp instanceof Field
     )
   ) and
diff --git a/java/ql/src/utils/model-generator/CaptureSummaryModels.ql b/java/ql/src/utils/model-generator/CaptureSummaryModels.ql
index 91767270c75..eb3ee0f8f53 100644
--- a/java/ql/src/utils/model-generator/CaptureSummaryModels.ql
+++ b/java/ql/src/utils/model-generator/CaptureSummaryModels.ql
@@ -223,7 +223,7 @@ string captureParameterToParameterFlow(TargetAPI api) {
   |
     result =
       asTaintModel(api, parameterAccess(source.asParameter()),
-        parameterAccess(sink.getPreUpdateNode().asExpr().(VarAccess).getVariable().(Parameter)))
+        parameterAccess(sink.getPreUpdateNode().asExpr().(VarAccess).getVariable()))
   )
 }
 
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/InterModuleTypeInference.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/InterModuleTypeInference.qll
index 1662a0055b1..4986164f859 100644
--- a/javascript/ql/lib/semmle/javascript/dataflow/internal/InterModuleTypeInference.qll
+++ b/javascript/ql/lib/semmle/javascript/dataflow/internal/InterModuleTypeInference.qll
@@ -157,7 +157,7 @@ private class AnalyzedImport extends AnalyzedPropertyRead, DataFlow::ValueNode {
       exports = MkAbstractProperty(TAbstractModuleObject(imported), "exports")
     |
       base = exports.getALocalValue() and
-      propName = astNode.(ImportSpecifier).getImportedName()
+      propName = astNode.getImportedName()
     )
     or
     // when importing CommonJS/AMD modules from ES2015, `module.exports` appears
@@ -168,7 +168,7 @@ private class AnalyzedImport extends AnalyzedPropertyRead, DataFlow::ValueNode {
       // CommonJS/AMD module generated by TypeScript compiler
       imported.getAStmt() instanceof ExportAssignDeclaration
     ) and
-    astNode.(ImportSpecifier).getImportedName() = "default" and
+    astNode.getImportedName() = "default" and
     base = TAbstractModuleObject(imported) and
     propName = "exports"
   }
diff --git a/python/ql/lib/semmle/python/frameworks/FastApi.qll b/python/ql/lib/semmle/python/frameworks/FastApi.qll
index c45e18c0292..d8e0f1f0883 100644
--- a/python/ql/lib/semmle/python/frameworks/FastApi.qll
+++ b/python/ql/lib/semmle/python/frameworks/FastApi.qll
@@ -163,7 +163,7 @@ private module FastApi {
       exists(Class cls, API::Node base |
         base = getModeledResponseClass(_).getASubclass*() and
         cls.getABase() = base.getAUse().asExpr() and
-        responseClass.getAnImmediateUse().asExpr().(ClassExpr) = cls.getParent()
+        responseClass.getAnImmediateUse().asExpr() = cls.getParent()
       |
         exists(Assign assign | assign = cls.getAStmt() |
           assign.getATarget().(Name).getId() = "media_type" and