C#: remove previous uses of isUninteresting

This commit is contained in:
Jami Cogswell
2022-12-08 17:12:26 -05:00
parent ff85e2f9f2
commit a1908be165
7 changed files with 6 additions and 21 deletions

View File

@@ -14,8 +14,7 @@ private predicate getRelevantUsages(string namespace, int usages) {
usages =
strictcount(Call c, ExternalApi api |
c.getTarget().getUnboundDeclaration() = api and
api.getNamespace() = namespace and
not api.isUninteresting()
api.getNamespace() = namespace
)
}

View File

@@ -12,11 +12,8 @@ private import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSumma
private import ExternalApi
private predicate relevant(ExternalApi api) {
not api.isUninteresting() and
(
api.isSupported() or
api instanceof FlowSummaryImpl::Public::NegativeSummarizedCallable
)
api.isSupported() or
api instanceof FlowSummaryImpl::Public::NegativeSummarizedCallable
}
from string info, int usages

View File

@@ -10,10 +10,7 @@ private import csharp
private import semmle.code.csharp.dispatch.Dispatch
private import ExternalApi
private predicate relevant(ExternalApi api) {
not api.isUninteresting() and
api.isSink()
}
private predicate relevant(ExternalApi api) { api.isSink() }
from string info, int usages
where Results<relevant/1>::restrict(info, usages)

View File

@@ -10,10 +10,7 @@ private import csharp
private import semmle.code.csharp.dispatch.Dispatch
private import ExternalApi
private predicate relevant(ExternalApi api) {
not api.isUninteresting() and
api.isSource()
}
private predicate relevant(ExternalApi api) { api.isSource() }
from string info, int usages
where Results<relevant/1>::restrict(info, usages)

View File

@@ -10,10 +10,7 @@ private import csharp
private import semmle.code.csharp.dispatch.Dispatch
private import ExternalApi
private predicate relevant(ExternalApi api) {
not api.isUninteresting() and
api.hasSummary()
}
private predicate relevant(ExternalApi api) { api.hasSummary() }
from string info, int usages
where Results<relevant/1>::restrict(info, usages)

View File

@@ -12,7 +12,6 @@ private import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSumma
private import ExternalApi
private predicate relevant(ExternalApi api) {
not api.isUninteresting() and
not api.isSupported() and
not api instanceof FlowSummaryImpl::Public::NegativeSummarizedCallable
}

View File

@@ -16,7 +16,6 @@ private import Telemetry.ExternalApi
from Call c, ExternalApi api
where
c.getTarget().getUnboundDeclaration() = api and
not api.isUninteresting() and
not api.isSupported() and
not api instanceof FlowSummaryImpl::Public::NegativeSummarizedCallable
select c, "Call to unsupported external API $@.", api, api.toString()