hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Add implementation note about why not targeting ESSA node

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2023-07-11 11:32:26 +02:00
parent 44c67171f2
commit a1225674ee
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -468,6 +468,7 @@ predicate runtimeJumpStep(Node nodeFrom, Node nodeTo) {
// function, while the default value itself will be in the scope that _defines_ the // function, while the default value itself will be in the scope that _defines_ the
// function. // function.
exists(ParameterDefinition param | exists(ParameterDefinition param |
// note: we go to the _control-flow node_ of the parameter, and not the ESSA node of the parameter, since for type-tracking, the ESSA node is not a LocalSourceNode, so we would get in trouble.
nodeFrom.asCfgNode() = param.getDefault() and nodeFrom.asCfgNode() = param.getDefault() and
nodeTo.asCfgNode() = param.getDefiningNode() nodeTo.asCfgNode() = param.getDefiningNode()
) )