hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11927 from mvogelgesang/express-rate-limit

Browse Source 
JS: Updated express-rate-limit example to match implementation examples f…
This commit is contained in:
Erik Krogh Kristensen
2023-01-23 14:37:50 +01:00
committed by GitHub
parent 05ecd2e015 a3ff0725a3
commit a10b45e0db
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/Security/CWE-770/examples/MissingRateLimitingGood.js
View File

@@ -3,7 +3,7 @@ var app = express();
// set up rate limiter: maximum of five requests per minute
var RateLimit = require('express-rate-limit');
var limiter = new RateLimit({
var limiter = RateLimit({
windowMs: 1*60*1000, // 1 minute
max: 5
});

15
javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimit/MissingRateLimitingGood.js
View File

@@ -1,18 +1,17 @@
var express = require('express');
var express = require("express");
var app = express();
// set up rate limiter: maximum of five requests per minute
var RateLimit = require('express-rate-limit');
var limiter = new RateLimit({
windowMs: 1*60*1000, // 1 minute
max: 5
var RateLimit = require("express-rate-limit");
var limiter = RateLimit({
windowMs: 1 * 60 * 1000, // 1 minute
max: 5,
});
// apply rate limiter to all requests
app.use(limiter);
app.get('/:path', function(req, res) {
app.get("/:path", function (req, res) {
let path = req.params.path;
if (isValidPath(path))
res.sendFile(path);
if (isValidPath(path)) res.sendFile(path);
});