hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 19:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Kotlin: Refactor useSimpleType to avoid some casts

Browse Source
This commit is contained in:
Ian Lynagh
2022-08-30 17:55:57 +01:00
parent f5d43b80ed
commit a07be192fa
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt
View File

@@ -667,11 +667,15 @@ open class KotlinUsesExtractor(
dimensions++ dimensions++
if (elementType.isPrimitiveArray()) if (elementType.isPrimitiveArray())
isPrimitiveArray = true isPrimitiveArray = true
if (((elementType as IrSimpleType).arguments.singleOrNull() as? IrTypeProjection)?.variance == Variance.IN_VARIANCE) { if (elementType is IrSimpleType) {
// Because Java's arrays are covariant, Kotlin will render Array<in X> as Object[], Array<Array<in X>> as Object[][] etc. if ((elementType.arguments.singleOrNull() as? IrTypeProjection)?.variance == Variance.IN_VARIANCE) {
componentType = replaceComponentTypeWithAny(s, dimensions - 1) // Because Java's arrays are covariant, Kotlin will render Array<in X> as Object[], Array<Array<in X>> as Object[][] etc.
elementType = pluginContext.irBuiltIns.anyType as IrSimpleType componentType = replaceComponentTypeWithAny(s, dimensions - 1)
break elementType = pluginContext.irBuiltIns.anyType
break
}
} else {
logger.warn("Unexpected element type representation ${elementType.javaClass} for ${s.render()}")
} }
elementType = elementType.getArrayElementType(pluginContext.irBuiltIns) elementType = elementType.getArrayElementType(pluginContext.irBuiltIns)
} }