hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use better sanitiser.

Browse Source
This commit is contained in:
Max Schaefer
2023-09-06 14:06:16 +01:00
parent 87364137df
commit a02f373e79
2 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/src/Security/CWE-601/examples/ServerSideUrlRedirectGood2.js
View File

@@ -1,13 +1,19 @@
const app = require("express")();
function isRelativePath(path) {
return !/^(\w+:)?[/\\]{2}/.test(path);
function isLocalUrl(path) {
try {
return (
new URL(path, "https://example.com").origin === "https://example.com"
);
} catch (e) {
return false;
}
}
app.get("/redirect", function (req, res) {
// GOOD: check that we don't redirect to a different host
let target = req.query["target"];
if (isRelativePath(target)) {
if (isLocalUrl(target)) {
res.redirect(target);
} else {
res.redirect("/");

12
javascript/ql/test/query-tests/Security/CWE-601/ServerSideUrlRedirect/ServerSideUrlRedirectGood2.js
View File

@@ -1,13 +1,19 @@
const app = require("express")();
function isRelativePath(path) {
return !/^(\w+:)?[/\\]{2}/.test(path);
function isLocalUrl(path) {
try {
return (
new URL(path, "https://example.com").origin === "https://example.com"
);
} catch (e) {
return false;
}
}
app.get("/redirect", function (req, res) {
// GOOD: check that we don't redirect to a different host
let target = req.query["target"];
if (isRelativePath(target)) {
if (isLocalUrl(target)) {
res.redirect(target);
} else {
res.redirect("/");